Skip to content

feat: implement Symbol.dispose and Symbol.asyncDisposable for ManagedRuntime #5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: next-minor
Choose a base branch
from
Open

feat: implement Symbol.dispose and Symbol.asyncDisposable for ManagedRuntime #5482

wants to merge 2 commits into from
+20 −0

Conversation

@patroza
Copy link
Member

@patroza patroza commented Sep 9, 2025

No description provided.

@patroza patroza requested a review from mikearnaldi as a code owner September 9, 2025 06:47
@github-project-automation github-project-automation bot moved this to Discussion Ongoing in PR Backlog Sep 9, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a2d5a3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc Major
@effect/sql-clickhouse Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-libsql Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-do Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major
@effect/workflow Major
@effect/ai Major
@effect/ai-amazon-bedrock Major
@effect/ai-anthropic Major
@effect/ai-google Major
@effect/ai-openai Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-bot effect-bot changed the base branch from main to next-minor September 9, 2025 06:48
@tim-smart
Copy link
Contributor

tim-smart commented Sep 9, 2025

Looks like safari is holding us back https://caniuse.com/mdn-javascript_builtins_symbol_dispose

@effect-bot effect-bot force-pushed the next-minor branch 7 times, most recently from febe6fe to bd017cf Compare September 10, 2025 02:54
@patroza
Copy link
Member Author

patroza commented Sep 10, 2025 •
edited
Loading

Looks like safari is holding us back https://caniuse.com/mdn-javascript_builtins_symbol_dispose

😢 and I guess unlike react native, we're not okay with requiring polyfills for safari.

@effect-bot effect-bot force-pushed the next-minor branch 12 times, most recently from b64c6b1 to 5306ee2 Compare September 17, 2025 01:46
@effect-bot effect-bot force-pushed the next-minor branch 11 times, most recently from 1ceeede to 4489360 Compare October 8, 2025 02:17
@effect-bot effect-bot force-pushed the next-minor branch 11 times, most recently from eeb94dd to 79a612d Compare October 20, 2025 15:28
@effect-bot effect-bot force-pushed the next-minor branch 2 times, most recently from 3f5ef2a to 4674ce9 Compare October 26, 2025 07:24
@eugene1g
Copy link

eugene1g commented Nov 12, 2025 •
edited
Loading

Looks like safari is holding us back https://caniuse.com/mdn-javascript_builtins_symbol_dispose

@tim-smart Would it be sufficient to conditionally add these methods only when Symbol.dispose / Symbol.asyncDispose are defined? Then this would become a no-op in environments that don't support it (e.g., Safari and older Node), but a net gain in more current runtimes.

@tim-smart
Copy link
Contributor

tim-smart commented Nov 12, 2025

Would it be sufficient to conditionally add these methods

I'm not sure how this can be made type safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

Assignees

No one assigned

Labels

next-minor

Projects

PR Backlog
Status: Discussion Ongoing

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@patroza @tim-smart @eugene1g @effect-bot